graphprotocol / indexer-rs

Rewrite of indexer-service in Rust with TAP payments implementation
Apache License 2.0
20 stars 19 forks source link

chore: release candidate 1.0.0 #202

Closed gusinacio closed 4 months ago

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9389552622

Details


Files with Coverage Reduction New Missed Lines %
common/src/tap/checks/deny_list_check.rs 1 93.64%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9389306851: -0.02%
Covered Lines: 3805
Relevant Lines: 5708

💛 - Coveralls
gusinacio commented 4 months ago

Shouldn't we also version indexer-config to 1.0.0-rc.1? Or best to wait for 1.0.0 to version it? And any opinions about indexer-common versionning?

Thanks for pointing out. Gonna update indexer-config. For indexer-common, I feel that, as a library and not an application, that should be versioned separately considering that other projects than indexer-rs will use it.

I'm not confident enough to release as a version 1.0.0 because I still consider it unstable.

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9404944913

Details


Files with Coverage Reduction New Missed Lines %
common/src/tap/checks/deny_list_check.rs 1 93.64%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9389306851: -0.02%
Covered Lines: 3805
Relevant Lines: 5708

💛 - Coveralls