search

graphprotocol / mission-control-indexer

Technical indexer documentation and infrastructure templates for the Mission Control testnet
21 stars 4 forks source link

Explorer (minor): fee transparency, number formatting/consistency #100

Closed crypto-crack closed 3 years ago

crypto-crack commented 3 years ago

Hi, I noticed some Explorer inconsistencies when completing P1M2. Will open separate Issues as I am not sure if they are all related. I worked on Google Chrome in a complete new instance/identity dedicated to the Graph.

The amount to unsignal (950 from 1000 GRT) and unstake (8799 from 10000) are lower than the ones I put it just minutes before. Probably some fee that I was not aware of? Might be good to explain in UI though. Also slight inconsistencies in the data (or labels) showing with regards to signal/reserve on Uniswap v2 on right side vs main section. Also some number formating/overlap at unstaking wallet balance on top right.

Please see screenshots below. Cheers, Freddy from Anyblock Analytics

TheGraph_Anyblock_Unstake-values-dont-match_01_20200918 TheGraph_Anyblock_signaled-1000GRT_unsignal-all-only-950GRT_01_20200918

trader-payne commented 3 years ago

https://github.com/graphprotocol/mission-control-indexer/issues/39#issuecomment-691690798

According to that ^ there is a 5% fee, and will be implemented in the UI soon

davekaj commented 3 years ago

The curation looks okay with the 5%

The staking looks weird, we need to look into it

davekaj commented 3 years ago

We should display the fee, we can get it from subgraph (where it is stored in parts per million):

graphNetwork.withdrawalFeePercentage / 100000
Now we have it set to 50000. so it would be 50000/1,000,000 = 0.05
Then do * 100 = 5% to display it in front end
trader-payne commented 3 years ago

This should all be fixed now. Feel free to reopen, or submit a new issue if something is wrong.