graphprotocol / mission-control-indexer

Technical indexer documentation and infrastructure templates for the Mission Control testnet
21 stars 4 forks source link

Profile Overview Description doesn't limit the number of characters one can use #120

Closed trader-payne closed 3 years ago

trader-payne commented 3 years ago

Title self explanatory, users are not word/character limited when setting the short description in their profile.

Also, the description doesn't break strings of text written in one block(?) either ( -- I don't know how to explain this, check the pic below, basically the first line of WOOO's)

image

The end result looks a little bit extreme lol (taken with full screen capture)

image

nenadjaja commented 3 years ago

Hahahah this is so funny. Easy fix though, we'll push it up with the next release

davekaj commented 3 years ago

Nena, whatever you pick as a character limit, I should also limit in the subgraph. We don't want people to be able to upload 1000000 characters in the subgraph to begin with. But we should both do it. Because the best I can do is either make it blank, or else slice the string to the char limit

nenadjaja commented 3 years ago

Yep this is implemented on staging, will push it up soon. Max length: 300 characters @davekaj

nenadjaja commented 3 years ago

This is fixed. We will have a more sophisticated char count (like we do in Everest) when I have more time. Currently drowning in work..

trader-payne commented 3 years ago

@nenadjaja I just realized this is present for website and repo fields too.

image

Should I open a new issue for this or should I remind you about it later?

nenadjaja commented 3 years ago

I have it in Linear, thanks! what should be the limit, I am not sure

trader-payne commented 3 years ago

Good question 😄