search

graphprotocol / mission-control-indexer

Technical indexer documentation and infrastructure templates for the Mission Control testnet
21 stars 4 forks source link

Query fees on participant profile is displayed as NaN #213

Closed juanmardefago closed 3 years ago

juanmardefago commented 3 years ago

On any deployment that you received query fees, it displays NaN instead of the correct amount of query fees received.

Here's an example: For deployment Qmbpwh32waJ21xgYLBw9ZV9v5ikehANXqQTaxErii7ypbT Explorer participant's profile (https://testnet.thegraph.com/profile/?id=0x9bae7565cdebe993ff6198c82f4b71c101d491f2&view=Indexing) image

Tsuki graph participant page (https://tsuki-graph.netlify.app/user/0x9bae7565cdebe993ff6198c82f4b71c101d491f2) image

Not sure if it's related to #210, might have been there already on the older version, since query fees are quite new and I had to scroll to the bottom of my profile to actually detect this bug.

trader-payne commented 3 years ago

I think this happens because the query fees are miniscule, lol Let's see when the real flood gates open, in a few days. But yeah, the handling with NaN shouldn't be there, I agree.

nenadjaja commented 3 years ago

Lol the numbers are so tiny that they broke my JS helpers. Should be fixed now. We have ~ 0 in that table and when you hover over it shows you the exact number in a tooltip. Not sure if it's the best approach, but NaN should be gone :)

trader-payne commented 3 years ago

@juanmardefago I'm going to close this issue, looks alright for me, feel free to reopen if this happens again 🙌🏻