Feature request - add redirect for non-existing views

graphprotocol / mission-control-indexer

Technical indexer documentation and infrastructure templates for the Mission Control testnet

21 stars 4 forks source link

Feature request - add redirect for non-existing views #250

Open koen84 opened 3 years ago

koen84 commented 3 years ago

If the profile view is something it something that doesn't exist (currently overview, subgraphs, curating, indexing & delegating) it displays a "blank" page. I think it would be wise to "redirect" to overview as "default" action.

Could be from a typo, could be an outdated bookmark, etc.

Example : https://testnet.thegraph.com/profile/?id=0x535ecc66fbed721507f41a686d867345cb6ac27e&view=NenaWillFix

trader-payne commented 3 years ago

I don't understand what's the behavior. Did you just replace the view with something of your own and it shows a blank page? Or was that there?

koen84 commented 3 years ago

Yes, i made up something random. (Came from typing wrong capitalisation on the other bug.)

The views are probably a casestatement, but default isn't defined (or filled as no content). My suggestion is to make that go to "overview". The reason is mostly future proofing, in case something gets changed. Though in copy pasting things might go wrong as well.

It's nothing critical, it's simply a bit more graceful imho.