search

graphprotocol / mission-control-indexer

Technical indexer documentation and infrastructure templates for the Mission Control testnet
21 stars 4 forks source link

Bug: Duplicate / Incorrect personal indexing statistics on the Explorer UI #66

Closed crypt1d closed 3 years ago

crypt1d commented 4 years ago

If one navigates to the "Indexing" tab under his profile, he should be able to see all the graphs that he is currently indexing. The stats shown there appear to be incorrect, though:

image

It seems that each deployment is shown twice. In addition, the deployments are shown by their txid instead of the graph ID, which is not consistent to what graph indexer status shows on the console:

Indexing Rules
┌────────────────────────────────────────────────┬──────────────────┬─────────────────────┬─────────────────────────┬───────────┬───────────┬──────────┬─────────────────────┬────────┐
│ deployment                                     │ allocationAmount │ parallelAllocations │ maxAllocationPercentage │ minSignal │ maxSignal │ minStake │ minAverageQueryFees │ custom │
├────────────────────────────────────────────────┼──────────────────┼─────────────────────┼─────────────────────────┼───────────┼───────────┼──────────┼─────────────────────┼────────┤
│ QmWTrJJ9W8h3JE19FhCzzPYsJ2tgXZCdUqnbyuo64ToTBN │ 50.0             │ 2                   │                         │           │           │          │                     │        │
├────────────────────────────────────────────────┼──────────────────┼─────────────────────┼─────────────────────────┼───────────┼───────────┼──────────┼─────────────────────┼────────┤
│ QmdbHP5ALcHda6UdCtZLYEwQJo7xTKKgUXMwMLLiCspYFE │ 100.0            │ 2                   │                         │           │           │          │                     │        │
├────────────────────────────────────────────────┼──────────────────┼─────────────────────┼─────────────────────────┼───────────┼───────────┼──────────┼─────────────────────┼────────┤
│ global                                         │ 0.01             │ 2                   │                         │           │           │          │                     │        │
└────────────────────────────────────────────────┴──────────────────┴─────────────────────┴─────────────────────────┴───────────┴───────────┴──────────┴─────────────────────┴────────┘

The "Started" time also appears to be incorrect at least for the older graph, which I started indexing more than 12 hrs ago (compared to the 4 hrs shown here).

rosewood5 commented 4 years ago

Looks like I have the same problem. The following commands were issued:

graph indexer rules set QmWTrJJ9W8h3JE19FhCzzPYsJ2tgXZCdUqnbyuo64ToTBN decisionBasis always allocationAmount 500 graph indexer rules set QmTXzATwNfgGVukV1fX2T6xw9f6LAYRVWpsdXyRWzUR2H9 decisionBasis always allocationAmount 750 graph indexer rules set QmSXzWZhbDgDg9YyDeivFqYBc1zxESyBYBH3W9CzmupYQd decisionBasis always allocationAmount 1000

Which resulted in this indexing rules configuration (the existing deployments were from the earlier mission):

┌────────────────────────────────────────────────┬──────────────────┬─────────────────────┬─────────────────────────┬───────────┬───────────┬──────────┬─────────────────────┬────────┬───────────────┐
│ deployment                                     │ allocationAmount │ parallelAllocations │ maxAllocationPercentage │ minSignal │ maxSignal │ minStake │ minAverageQueryFees │ custom │ decisionBasis │
├────────────────────────────────────────────────┼──────────────────┼─────────────────────┼─────────────────────────┼───────────┼───────────┼──────────┼─────────────────────┼────────┼───────────────┤
│ QmXKwSEMirgWVn41nRzkT3hpUBw29cp619Gx58XW6mPhZP │ 100.0            │ 2                   │                         │           │           │          │                     │        │ always        │
├────────────────────────────────────────────────┼──────────────────┼─────────────────────┼─────────────────────────┼───────────┼───────────┼──────────┼─────────────────────┼────────┼───────────────┤
│ QmTXzATwNfgGVukV1fX2T6xw9f6LAYRVWpsdXyRWzUR2H9 │ 100.0            │ 2                   │                         │           │           │          │                     │        │ always        │
├────────────────────────────────────────────────┼──────────────────┼─────────────────────┼─────────────────────────┼───────────┼───────────┼──────────┼─────────────────────┼────────┼───────────────┤
│ global                                         │ 0.01             │ 2                   │                         │           │           │          │                     │        │ rules         │
├────────────────────────────────────────────────┼──────────────────┼─────────────────────┼─────────────────────────┼───────────┼───────────┼──────────┼─────────────────────┼────────┼───────────────┤
│ QmWTrJJ9W8h3JE19FhCzzPYsJ2tgXZCdUqnbyuo64ToTBN │ 500.0            │ 2                   │                         │           │           │          │                     │        │ always        │
├────────────────────────────────────────────────┼──────────────────┼─────────────────────┼─────────────────────────┼───────────┼───────────┼──────────┼─────────────────────┼────────┼───────────────┤
│ QmTXzATwNfgGVukV1fX2T6xw9f6LAYRVWpsdXyRWzUR2H9 │ 750.0            │ 2                   │                         │           │           │          │                     │        │ always        │
├────────────────────────────────────────────────┼──────────────────┼─────────────────────┼─────────────────────────┼───────────┼───────────┼──────────┼─────────────────────┼────────┼───────────────┤
│ QmSXzWZhbDgDg9YyDeivFqYBc1zxESyBYBH3W9CzmupYQd │ 1000.0           │ 2                   │                         │           │           │          │                     │        │ always        │
└────────────────────────────────────────────────┴──────────────────┴─────────────────────┴─────────────────────────┴───────────┴───────────┴──────────┴─────────────────────┴────────┴───────────────┘

It appears the allocationAmount was taken multiple times based on these transactions:

Subgraph Name Subgraph ID Allocation Amount Transaction Transferred Amount Multiplier
Uniswap V2 QmWTrJJ9W8h3JE19FhCzzPYsJ2tgXZCdUqnbyuo64ToTBN 500GRT Etherscan link 1500GRT 3x
Moloch QmTXzATwNfgGVukV1fX2T6xw9f6LAYRVWpsdXyRWzUR2H9 750GRT Etherscan link 1500GRT 2x
Synthetix QmSXzWZhbDgDg9YyDeivFqYBc1zxESyBYBH3W9CzmupYQd 1000GRT Etherscan link 2000GRT 2x

The Current Indexing screen on the explorer looks like this:

image

There may be overlap with #67 here.

trader-payne commented 3 years ago

As stated in the issue @rosewood5 linked (https://github.com/graphprotocol/mission-control-indexer/issues/67), this is expected behavior, and happens due to parallelAllocations being set to different values. Ford is also tracking this separately here: https://github.com/graphprotocol/indexer/issues/71

Will close this issue for the time being, as the UI will likely be reworked :)