Closed gunray88 closed 4 years ago
I think this bug was in the subgraph (not the UI), and might have been fixed. I'll check
I will look into it!
FYI I have retried but still no nickname change reflected in UI.
Thanks, sorry we have not got to it yet.
We are working on a new set of contracts and a whole new environment, therefore most of the bug fixes are going to a frontend that is not yet shared with the indexers. It is likely we will not push the update to the current version you are using right now.
However, we still will keep this issue open until it is confirmed it is fixed
Weird, I tried changing my old.eth
to a new sub.newdomain.eth
and it correctly updates right after the TX is confirmed.
Going back to profile without refreshing the page makes it half working.
Refreshing the webpage returns everything to the state before the update TX was sent.
Yeah I know why this is happening, it's actually in the subgraph. But I think it's fixed, in the subgraph that's referencing the Phase 2 contracts - which we haven't released yet, so Explorer is using the old contracts. @davekaj is this true what I am saying (that the bug is fixed)? :)
To confirm the above, I just queried the subgraph we are using with your Ethereum account @trader-payne and I can see you are still payne-coretechs
, so it didn't update in the subgraph :-(
We don't allow subdomains to be registered as of now. So they will not resolve, and therefore will not update. It will stay as the previous name you had, so the way that it played out for Trader Payne is what I would expect.
Maybe we need to add some copy saying we do not support subdomains?
I've got related bug that seems to be different : 1 ETH address with 2 ENS names.
I could go from ENS a to ENS b. But going back again to ENS a i needed a second attempt and going back again to ENS b doesn't work at all.
I haven't tried going to a 3rd ENS name (which then i'd need to register first to try).
I pushed a fix for this that should fix both problems. Since we moved on from the old contracts, there is no easy way to retest gunrays problem. So lets move on from that, as I believe it is fixed
Koens problem was confirmed fixed - I tested myself
Closing
I have accidentaly logged in with an incorrect ETH address (0x2DaE1076B5DE55676E575908070e1a5B494c908A) via metamask to the explorer. Then I have registered an ENS "gunray.eth" to that, incorrect, ETH addresss.
After submitting the edit profile tx in the explorer my nickname properly showed up.
Then I realized it wasn't my indexer address so I tried to do the following:
Change all (registrant, controller, address record) in ENS to the correct address (0x5e4cE22167204dAa30489c91e3B5d6B498876d78) https://app.ens.domains/name/gunray.eth/details
Swapped to correct address in metamask and logged in into explorer with it. Then I tried several times to submit the nickname change, example latest tx: https://rinkeby.etherscan.io/tx/0xc8dc3878043fff7854fcc557dacde85865f63ce28f004735e0428be483fc2f70
But the ENS nickname does not get pulled into explorer, just the address is shown.
I have even registered a new ENS for the incorrect address and changed to that one in the explorer while trying to circumvent the issue but it did not help. However, that new ENS is showing up on the incorrect eth account in explorer:
So, I was able to change ENS name in explorer profile for 0x2DaE1076B5DE55676E575908070e1a5B494c908A from gunray.eth to wrongly.eth; but I was not able to set gunray.eth to my correct indexer address 0x5e4cE22167204dAa30489c91e3B5d6B498876d78