Overloaded ABI functions treated differently in graph-node and generated code

graphprotocol / support

Community support for the Hosted Service of The Graph

https://thegraph.com/

10 stars 3 forks source link

Overloaded ABI functions treated differently in graph-node and generated code #48

Closed Jannis closed 4 years ago

Jannis commented 4 years ago

ABIs that contain two overloaded variants of the same function, e.g. symbol result in generated code that has symbol and symbol1, one for each variant. However, when calling symbol and symbol1 from mappings, graph-node always picks the same variant to encode/decode inputs/outputs.

This causes EthereumValue conversion errors if e.g. the expected return types of symbol and symbol1 vary (e.g. one returning string, the other returning Bytes).

Jannis commented 4 years ago

PRs that will (together) fix the issue:

[x] https://github.com/graphprotocol/ethabi/pull/11 (also submitted upstream: https://github.com/paritytech/ethabi/pull/166)
[x] https://github.com/graphprotocol/graph-ts/pull/100
[x] https://github.com/graphprotocol/graph-cli/pull/415
[x] https://github.com/graphprotocol/graph-node/pull/1440

Jannis commented 4 years ago

Bonus PRs:

[x] https://github.com/graphprotocol/graph-cli/pull/414 (to add graph test)
[x] https://github.com/graphprotocol/graph-node/pull/1441 (an integration test for this particular issue based on graph test)