graphql-compose / graphql-compose-elasticsearch

Hide Elastic Search REST API behind GraphQL.
https://graphql-compose.herokuapp.com/elasticsearch/
MIT License
583 stars 77 forks source link

Update Aggs - replace __ with [.dot] recursively #142

Closed ajmalmsali closed 2 years ago

ajmalmsali commented 2 years ago

Nested keys with __ are not transformed

for e.g, filter: { bool: { filter: [ { nested: { path: "string_facets" query: { bool: { filter: [ { terms: { string_facets__facet_name: { value: "make" } } } { terms: { string_facets__facet_value: { value: "Omron" } } } ] } } } } { nested: { path: "string_facets" query: { bool: { filter: [ { term: { string_facets__facet_name: { value: "roHs" } } } { term: { string_facets__facet_value: { value: "Compliant" } } } ] } } } } ] } }

    were not replaced with dots, as we were having the rules passed in, as it is,
nodkz commented 2 years ago

Could you please fix prettier errors (code formatting)?

ajmalmsali commented 2 years ago

Updated, was under the impression, it got done in post-commit, thanks for commenting

nodkz commented 2 years ago

Good catch and fix 👍

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 5.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: