graphql-compose / graphql-compose-mongoose

Mongoose model converter to GraphQL types with resolvers for graphql-compose https://github.com/nodkz/graphql-compose
MIT License
708 stars 94 forks source link

Extend intro README.md code example with basic usage demo (ref #330). #343

Closed sgpinkus closed 3 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #343 (ead4c68) into master (e179910) will not change coverage. The diff coverage is n/a.

:exclamation: Current head ead4c68 differs from pull request most recent head 93ba444. Consider uploading reports for the commit 93ba444 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files          57       57           
  Lines        2186     2186           
  Branches      665      665           
=======================================
  Hits         2029     2029           
  Misses        155      155           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e179910...93ba444. Read the comment docs.

nodkz commented 3 years ago

@sgpinkus thanks a lot 🙏

I simplified a little bit demo for easy understanding of what is really happening in it. Also, I converted graphql call from positional arguments to one object argument. It will remain the only way that will be available in graphql-js v 16.

sgpinkus commented 3 years ago

Cool thanks!

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 9.4.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: