graphql-compose / graphql-compose-mongoose

Mongoose model converter to GraphQL types with resolvers for graphql-compose https://github.com/nodkz/graphql-compose
MIT License
709 stars 94 forks source link

Fix issue #415: removeMany should not throw an error if deleteCount equal 0 #416

Closed francois-spectre closed 1 year ago

francois-spectre commented 1 year ago

RemoveMany should not throw an error if deleteCount equal 0 to keep same behaviour with mongoose v5 and v6.

Fix issue #415

codecov-commenter commented 1 year ago

Codecov Report

Base: 92.54% // Head: 92.54% // No change to project coverage :thumbsup:

Coverage data is based on head (3a81ff2) compared to base (c1ea275). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #416 +/- ## ======================================= Coverage 92.54% 92.54% ======================================= Files 57 57 Lines 2213 2213 Branches 681 681 ======================================= Hits 2048 2048 Misses 163 163 Partials 2 2 ``` | [Impacted Files](https://codecov.io/gh/graphql-compose/graphql-compose-mongoose/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/resolvers/removeMany.ts](https://codecov.io/gh/graphql-compose/graphql-compose-mongoose/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Jlc29sdmVycy9yZW1vdmVNYW55LnRz) | `78.94% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nodkz commented 1 year ago

Good catch and brilliant fix! Thanks 👍

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 9.7.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: