graphql-compose / graphql-compose-mongoose

Mongoose model converter to GraphQL types with resolvers for graphql-compose https://github.com/nodkz/graphql-compose
MIT License
709 stars 94 forks source link

chore: fix mongoose 7 compatibility #427

Closed meabed closed 1 year ago

meabed commented 1 year ago

With reference to this issues: fixes https://github.com/graphql-compose/graphql-compose-mongoose/issues/426

I have tested it and released the version for me to use until this is merged here: https://npmjs.com/package/graphql-compose-mongoose-extended

meabed commented 1 year ago

@nodkz would you please check and let me know whats is needed to merge this. The CI is passing here: https://github.com/meabed/graphql-compose-mongoose/actions

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 36.36% and project coverage change: -1.07 :warning:

Comparison is base (91cdfd0) 92.54% compared to head (5f771fe) 91.48%.

:exclamation: Current head 5f771fe differs from pull request most recent head 19e19c4. Consider uploading reports for the commit 19e19c4 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #427 +/- ## ========================================== - Coverage 92.54% 91.48% -1.07% ========================================== Files 57 57 Lines 2213 2277 +64 Branches 665 743 +78 ========================================== + Hits 2048 2083 +35 - Misses 163 191 +28 - Partials 2 3 +1 ``` | [Impacted Files](https://codecov.io/gh/graphql-compose/graphql-compose-mongoose/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/composeMongoose.ts](https://codecov.io/gh/graphql-compose/graphql-compose-mongoose/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2NvbXBvc2VNb25nb29zZS50cw==) | `95.83% <ø> (ø)` | | | [src/resolvers/helpers/filterOperators.ts](https://codecov.io/gh/graphql-compose/graphql-compose-mongoose/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Jlc29sdmVycy9oZWxwZXJzL2ZpbHRlck9wZXJhdG9ycy50cw==) | `93.33% <ø> (-0.64%)` | :arrow_down: | | [src/resolvers/removeById.ts](https://codecov.io/gh/graphql-compose/graphql-compose-mongoose/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Jlc29sdmVycy9yZW1vdmVCeUlkLnRz) | `73.52% <0.00%> (-20.02%)` | :arrow_down: | | [src/resolvers/removeMany.ts](https://codecov.io/gh/graphql-compose/graphql-compose-mongoose/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Jlc29sdmVycy9yZW1vdmVNYW55LnRz) | `66.66% <0.00%> (-12.29%)` | :arrow_down: | | [src/fieldsConverter.ts](https://codecov.io/gh/graphql-compose/graphql-compose-mongoose/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2ZpZWxkc0NvbnZlcnRlci50cw==) | `92.59% <50.00%> (-0.37%)` | :arrow_down: | | [src/resolvers/helpers/validate.ts](https://codecov.io/gh/graphql-compose/graphql-compose-mongoose/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Jlc29sdmVycy9oZWxwZXJzL3ZhbGlkYXRlLnRz) | `96.29% <75.00%> (-3.71%)` | :arrow_down: | | [src/resolvers/removeOne.ts](https://codecov.io/gh/graphql-compose/graphql-compose-mongoose/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Jlc29sdmVycy9yZW1vdmVPbmUudHM=) | `89.47% <75.00%> (-1.96%)` | :arrow_down: | | [src/utils/testHelpers.ts](https://codecov.io/gh/graphql-compose/graphql-compose-mongoose/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3V0aWxzL3Rlc3RIZWxwZXJzLnRz) | `88.63% <100.00%> (ø)` | | | [src/resolvers/count.ts](https://codecov.io/gh/graphql-compose/graphql-compose-mongoose/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Jlc29sdmVycy9jb3VudC50cw==) | `77.27% <0.00%> (-3.68%)` | :arrow_down: | | ... and [27 more](https://codecov.io/gh/graphql-compose/graphql-compose-mongoose/pull/427?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nodkz commented 1 year ago

@meabed It was very-very clean! 🔥 Thank you very much for your contribution. 👍

nodkz commented 1 year ago

Published to npm as 9.8.0

PS. It's strange that semantic-release didn't write a comment itself.

meabed commented 1 year ago

It publish tag.

yea, I could enable the GitHub comment plug-in if you need.

Because I added release config file as v19 changed the commit analyser default.

nodkz commented 1 year ago

Yep, it will be amazing to add the comment plug-in. It provides a great status info.

I saw a lot repos where code PR is merged but when it will be published is an open question. And SR comments greatly helps to inform contributors when package publishing appears.

meabed commented 1 year ago

Yes sounds good will open a PR shortly