Closed meabed closed 1 year ago
@nodkz would you please check and let me know whats is needed to merge this. The CI is passing here: https://github.com/meabed/graphql-compose-mongoose/actions
Patch coverage: 36.36
% and project coverage change: -1.07
:warning:
Comparison is base (
91cdfd0
) 92.54% compared to head (5f771fe
) 91.48%.:exclamation: Current head 5f771fe differs from pull request most recent head 19e19c4. Consider uploading reports for the commit 19e19c4 to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@meabed It was very-very clean! 🔥 Thank you very much for your contribution. 👍
Published to npm as 9.8.0
PS. It's strange that semantic-release didn't write a comment itself.
It publish tag.
yea, I could enable the GitHub comment plug-in if you need.
Because I added release config file as v19 changed the commit analyser default.
Yep, it will be amazing to add the comment plug-in. It provides a great status info.
I saw a lot repos where code PR is merged but when it will be published is an open question. And SR comments greatly helps to inform contributors when package publishing appears.
Yes sounds good will open a PR shortly
With reference to this issues: fixes https://github.com/graphql-compose/graphql-compose-mongoose/issues/426
I have tested it and released the version for me to use until this is merged here: https://npmjs.com/package/graphql-compose-mongoose-extended