graphql-compose / graphql-compose-mongoose

Mongoose model converter to GraphQL types with resolvers for graphql-compose https://github.com/nodkz/graphql-compose
MIT License
709 stars 94 forks source link

resolvers skip asynchronous validators #442

Open m-lyon opened 2 months ago

m-lyon commented 2 months ago

The validateDoc function used in many resolvers, e.g. updateById, createOne, found here will call doc.validateSync for mongoose >= v7. validateSync does not run asynchronous validators, and instead skips them. This leads to validation being silently skipped within this package.

Since validateDoc is an asynchronous function, and awaits for validations in mongoose < v7, it seems that there is no good reason to not await for validation in the >= v7 case as well.

Happy to make a pull request if the maintainers agree.