search

graphql-crystal / benchmarks

GraphQL server benchmarks
MIT License
88 stars 30 forks source link

Warmup servers prior to executing benchmarks #219

Closed kyri-petrou closed 1 year ago

kyri-petrou commented 1 year ago

Hi there 👋 I'm looking to add another Scala GraphQL library to the benchmarks. When I first looked at the current results I was a bit surprised that Sangria (Scala) was performing this badly. After looking at the benchmarking script, it seems that the servers are not warmed up prior to being benchmarked.

The JVM has a notoriously bad cold-start performance (see related post here), so any GraphQL libraries from JVM languages (Java, Kotlin, Scala, etc.) being benchmarked will show as having very poor performance if the server is not warmed up prior to measuring request latencies.

A very simple way to warmup the servers is to execute this line twice, discarding the results from the first invocation. Ideally, the first invocation should be with a smaller number of connections to prevent overwhelming the server as it warms up. I believe that this might also help resolve #217.

I'm happy to create a PR if you agree with this approach

tusharmath commented 1 year ago

The other thing about these benchmarks are that it doesn't really test GraphQL capabilities. Instead it tries to benchmark the webserver.

We prefer benchmarking on https://github.com/tailcallhq/graphql-benchmarks which are a lot more thorough.

jgillich commented 1 year ago

I agree about warming up, PR welcome.

it doesn't really test GraphQL capabilities. Instead it tries to benchmark the webserver.

static-rust is a literal webserver benchmark, and the difference between that one and async-graphql/juniper is over 2x. So it's far from "only" benchmarking webservers. But it could certainly be improved (#190), note that this was a side project that I hacked together in a weekend :wink: