search

graphql-devise / graphql_devise

GraphQL interface on top devise_token_auth
MIT License
200 stars 39 forks source link

cannot use newer version of rubocop ( 1.18, 1.19, 1.20 ) with the graphql-devise gem #195

Closed Qchmqs closed 3 years ago

Qchmqs commented 3 years ago

https://github.com/graphql-devise/graphql_devise/blob/e9c9a8f6cf8ad9851261e907347e7a3c8d635e3e/.rubocop.yml#L94

Error: The Layout/AlignHash cop has been renamed to Layout/HashAlignment.

00dav00 commented 3 years ago

Hi @Qchmqs , we are keeping this version of rubocop configuration to be compatible with older versions of ruby. We are planning to update it after removing support for them in V1 release. What we do is keep a different rubocop config file uncommited in our locals. Perhaps that can work you as well in the mean time.

Qchmqs commented 3 years ago

hi @00dav00 , it's causing me problems when I tried to setup a linting job in CircleCi, do you know of a way to tell rubocop to ignore gem introduced lints ?

mcelicalderon commented 3 years ago

@Qchmqs I don't think the default behavior is to inherit config from gems. You can do that with https://docs.rubocop.org/rubocop/configuration.html#inheriting-configuration-from-a-dependency-gem but you shouldn't get that by default. I would advise checking your config file again. Maybe an inherited config is doing gem files inheritance