search

graphql-devise / graphql_devise

GraphQL interface on top devise_token_auth
MIT License
197 stars 36 forks source link

Add GraphQL 2 support #222

Closed mcelicalderon closed 1 year ago

mcelicalderon commented 2 years ago

Adds support for graphql 2.0.

Still need to update readme, but you just need a few simple changes in your code to support it.

Defining 

field_class GraphqlDevise::Types::BaseField

In your MutationType and QueryType should be enough. If you already define a custom field class, you can include our concern FieldAuthentication

Resolves #228

wolak88 commented 2 years ago

@mcelicalderon I think graphql-ruby gem is already on version 2.0.11. Do you plan to support it any time soon?

mcelicalderon commented 2 years ago

Hey @wolak88! Sadly I think @00dav00 and I have been pretty busy lately. Not sure if we'll be able to get to this, soon. Sadly, as discussed in another thread, supporting gql 2.0 will take more work than expected given the breaking changes in that gem, and we have to figure out a way to use the new api. Anyone welcome to give it a try, as usual 🙂 and if not, I hope we can get back to this MR, soon

mcelicalderon commented 1 year ago

@00dav00 can you please review? Apparently this was a bit simpler than expected, still need to validate a couple of things, but I Think we can release this without the need to bump to v1 yet.