Change profiling information to Apollo Trace format

graphql-dotnet / conventions

GraphQL Conventions Library for .NET

MIT License

233 stars 63 forks source link

Change profiling information to Apollo Trace format #167

Closed raudabaugh closed 5 years ago

raudabaugh commented 5 years ago

This changes the behavior of RequestHandler when profiling is enabled to follow the Apollo Tracing spec, required for using tools such as Apollo Engine. The spec is essentially a superset of the fields that were being added by ProfilingResultEnricher.

Since this extension was already implemented upstream in graphql-dotnet, this also helps to avoid having to maintain conflicting profiling extensions.

tlil commented 5 years ago

Great. This has been on my list. Thanks for the PR.