Upgrade GraphQL.NET dependency to version 3.0.0

graphql-dotnet / conventions

GraphQL Conventions Library for .NET

MIT License

233 stars 63 forks source link

Upgrade GraphQL.NET dependency to version 3.0.0 #194

Closed schabannes closed 3 years ago

schabannes commented 5 years ago

Update GraphQL.Net to the latest ~preview~ version (3.0.0)
Replace UserContextWrapper by new GraphQL.Net UserContext dictionary
~Rename IdGraphType name from 'ID' to 'Identity' to avoid clash with GraphQL.Net internal IdGraphType~
Fix unit tests

sungam3r commented 5 years ago

3.0.0-preview-1271 is already not the latest version :)

yokan87 commented 4 years ago

@tlil @sungam3r @schabannes Hi, is it planned to continue this pull request, or are there any other ways to use this library together with the current GraphQL-Dotnet 3.0.0 preview? In the Readme of the graphql-dotnet library it is mentioned that the 2.4.0 has many known issues and as I have some problems with the reliability of subscriptions, I wanted to proof if the latest preview of the libraries would fix it.

Kind regards

tlil commented 4 years ago

Hi @jdomnick - yes, I'm planning to get back to this soon. Feel free to have a stab at it in the meantime ;-)

schabannes commented 4 years ago

Includes #206

tlil commented 4 years ago

Thanks, @schabannes - I'm getting 3 unit test failures when running locally. Have you looked at those yet? Will review more closely over the weekend.

schabannes commented 4 years ago

@till, I fixed the test. Something was wrong in the last merge from master. I did review manually and it looks alright now, but an extra pair of eyes is always better.

tlil commented 3 years ago

Thank you, all! This is now published to NuGet: https://www.nuget.org/packages/GraphQL.Conventions/3.0.0

https://github.com/graphql-dotnet/conventions/releases/tag/v3.0.0