search

graphql-dotnet / conventions

GraphQL Conventions Library for .NET
MIT License
233 stars 63 forks source link

graphql-dotnet#2549 Added support for Extensions #222

Closed Popeye4242 closed 2 years ago

Popeye4242 commented 3 years ago

This pull-request requires a change in the graphql-dotnet library

graphql-dotnet#2549 graphql-dotnet#2550 (requires updated graphql package)

tlil commented 2 years ago

This pull-request requires a change in the graphql-dotnet library

@Popeye4242 ^ - what's the state of this? :-)

Popeye4242 commented 2 years ago

https://github.com/graphql-dotnet/graphql-dotnet/issues/2549#issuecomment-844272207

The upstream PR will probably not be merged.

tlil commented 2 years ago

Okay, so fine with me closing this PR?

Popeye4242 commented 2 years ago

Yeah.

Shane32 commented 2 years ago

Keep an eye on the other PR because we may address it in the next major version of GraphQL.NET

tlil commented 2 years ago

Keep an eye on the other PR because we may address it in the next major version of GraphQL.NET

Cool. Thanks, @Shane32. Can re-open this PR if/when that happens :-)

sungam3r commented 2 years ago

Hi guys, I had a long break from the OSS this summer, so PRs have accumulated a lot. I do not lose hope to review them in winter.

sungam3r commented 2 years ago

https://github.com/graphql-dotnet/graphql-dotnet/pull/2719