graphql-dotnet / conventions

GraphQL Conventions Library for .NET
MIT License
233 stars 63 forks source link

GraphQL7 #233

Closed SimonCropp closed 1 year ago

floge07 commented 2 years ago

What's the status of this PR? Are there still tasks open? Anything I could help with?

BoBiene commented 1 year ago

@sungam3r & @Shane32 ping ;)

Shane32 commented 1 year ago

@tlil Can you review, merge and publish? I can't publish.

If you like, you can set up a NuGet 'team', move the package to the team, and share access to me. Then I can download the NuGet API keys, configure a repo secret, configure a publish GitHub Action workflow, and then all of us maintainers can publish a new version with a couple clicks directly from GitHub, as we do in the other repos. It will also allow me to update the API key annually.

tlil commented 1 year ago

@tlil Can you review, merge and publish? I can't publish.

Will do.

If you like, you can set up a NuGet 'team', move the package to the team, and share access to me. Then I can download the NuGet API keys, configure a repo secret, configure a publish GitHub Action workflow, and then all of us maintainers can publish a new version with a couple clicks directly from GitHub, as we do in the other repos. It will also allow me to update the API key annually.

👍

tlil commented 1 year ago

@Shane32 note that it's being published to NuGet from AppVeyor at the moment, so moving it all over to GitHub Actions as you suggested would be fab! :-) Will bump and tag this as 7.0.0 now and circle back on setting up a NuGet team and moving the package hopefully later today. Thanks!

tlil commented 1 year ago

CleanShot 2022-11-11 at 20 07 32 @Shane32 - can you ping me your NuGet username, and I'll get you added to the NuGet Org that's now listed as the sole package owner?

Shane32 commented 1 year ago

It's Shane32

https://www.nuget.org/profiles/Shane32

Shane32 commented 1 year ago

Thanks - I'll set up the publish script over this weekend.

Shane32 commented 1 year ago

Perhaps you can disconnect Appveyor when I'm done.

tlil commented 1 year ago

Perhaps you can disconnect Appveyor when I'm done.

Yep sounds good. Just gimme a shout when you've got the other pieces in place. Thanks!

Shane32 commented 1 year ago

I have not forgotten btw, just not got to it yet.