graphql-dotnet / conventions

GraphQL Conventions Library for .NET
MIT License
233 stars 63 forks source link

Remove data loader listener class #247

Closed Shane32 closed 1 year ago

Shane32 commented 1 year ago

It looks like the data loader listener was intended for GraphQL.NET prior to v3; after v3, IDataLoaderResult was added and the execution strategy is natively aware of data loader results. @tlil can you verify? There is a data loader listener class in GraphQL.DataLoader which sets up the AsyncLocal instance of the data loader collection, but it doesn't seem that it relates here and is necessary in either case. Also, there exists tests which verify that IDataLoaderResult<T> values are unwrapped.

tlil commented 1 year ago

Yup, sounds about right. Thanks