search

graphql-dotnet / parser

A lexer and parser for GraphQL in .NET
MIT License
216 stars 43 forks source link

Expose parameterless ctors for AST nodes #316

Closed sungam3r closed 1 year ago

Shane32 commented 1 year ago

Let's mark them as deprecated. Ok?

codecov-commenter commented 1 year ago

Codecov Report

Merging #316 (978fcb0) into master (0123f9d) will not change coverage. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files          85       85           
  Lines        4892     4892           
  Branches      477      477           
=======================================
  Hits         4708     4708           
  Misses        184      184
Impacted Files Coverage Δ
src/GraphQLParser/AST/GraphQLComment.cs 100.00% <ø> (ø)
src/GraphQLParser/AST/ASTListNode.cs 69.23% <100.00%> (ø)
...rser/AST/Definitions/GraphQLArgumentsDefinition.cs 80.00% <100.00%> (ø)
...rser/AST/Definitions/GraphQLDirectiveDefinition.cs 80.00% <100.00%> (ø)
...arser/AST/Definitions/GraphQLEnumTypeDefinition.cs 82.35% <100.00%> (ø)
...rser/AST/Definitions/GraphQLEnumValueDefinition.cs 80.00% <100.00%> (ø)
...ser/AST/Definitions/GraphQLEnumValuesDefinition.cs 80.00% <100.00%> (ø)
...ser/AST/Definitions/GraphQLExecutableDefinition.cs 60.00% <100.00%> (ø)
...QLParser/AST/Definitions/GraphQLFieldDefinition.cs 80.95% <100.00%> (ø)
...LParser/AST/Definitions/GraphQLFieldsDefinition.cs 80.00% <100.00%> (ø)
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sungam3r commented 1 year ago

🤔 not needed anymore after https://github.com/graphql-dotnet/graphql-dotnet/pull/3599