search

graphql-dotnet / parser

A lexer and parser for GraphQL in .NET
MIT License
216 stars 43 forks source link

Use AsTask() #349

Closed sungam3r closed 1 year ago

sungam3r commented 1 year ago

See notes in #332.

sungam3r commented 1 year ago

CA2012 nowarn still exists for tests

codecov-commenter commented 1 year ago

Codecov Report

Merging #349 (ebd092a) into master (cdd6106) will not change coverage. The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files          89       89           
  Lines        4975     4975           
  Branches      494      494           
=======================================
  Hits         4788     4788           
  Misses        187      187
Files Coverage Δ
src/GraphQLParser/Visitors/SDLPrinterExtensions.cs 100.00% <100.00%> (ø)
src/GraphQLParser/Visitors/SDLSorter.cs 100.00% <100.00%> (ø)
Shane32 commented 1 year ago

I did not use AsTask so as to be sure that there was no allocation occurring. But whatever you think.

Shane32 commented 1 year ago

Also note for SDLSorter that it is impossible to run asynchronously since it uses a static instance (cannot be derived) and the options class has no async members. (If I remember correctly.)

sungam3r commented 1 year ago

изображение

Shane32 commented 1 year ago

Excellent!