graphql-editor / graphql-zeus

GraphQL client and GraphQL code generator with GraphQL autocomplete library generation ⚡⚡⚡ for browser,nodejs and react native ( apollo compatible )
https://graphqleditor.com/docs/zeus
MIT License
1.95k stars 106 forks source link

fix:346 Error encoding arrays of custom scalars #379

Closed Vishal-Sikka closed 1 year ago

Vishal-Sikka commented 1 year ago

code has been adjusted to handle arrays of custom scalar types

fix: #346 /claim #346

aexol commented 1 year ago

No way, this is not the correct approach. You should not seek for the UUID but make it work for all the custom scalars with array

Vishal-Sikka commented 1 year ago

No way, this is not the correct approach. You should not seek for the UUID but make it work for all the custom scalars with array

adjusted code to handle arrays of custom scalar types

aexol commented 1 year ago

Ok, there is even no mock no nothing, so you are testing against schema which doesn't have the so called scalar? Closing

Vishal-Sikka commented 1 year ago

Ok, there is even no mock no nothing, so you are testing against schema which doesn't have the so called scalar? Closing

i have tested what user had issue with, i could have got more clarification if you have defined specific requirements, just read user's issue on #346 with point of view of some one is non graphql-zeus user , probably you should have create new issue with proper details

akansh-bansal commented 1 year ago

i want to pick it up @aexol could you clarify your requirements ?