search

graphql-elixir / graphql

GraphQL Elixir
Other
858 stars 45 forks source link

Visitor and executor refactorings #87

Closed freshtonic closed 8 years ago

freshtonic commented 8 years ago

This needs breaking up into multiple PRs.

I'll do that in the next day or two.

This PR depends on https://github.com/graphql-elixir/graphql/pull/90

joshprice commented 8 years ago

Is this ready to merge yet?

freshtonic commented 8 years ago

No but I'll work on it today On Fri, 20 May 2016 at 23:48, Josh Price notifications@github.com wrote:

Is this ready to merge yet?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/graphql-elixir/graphql/pull/87#issuecomment-220610188

joshprice commented 8 years ago

We'll look at adding the context arg into resolvers and batch up with any other breaking changes.

Not sure of whether this change benefits schema code that much:

https://github.com/graphql/graphql-js/commit/d7cc6f9aed462588291bc821238650c98ad53580