Extract GraphiQL from core Endpoint plug

graphql-elixir / plug_graphql

Plug (Phoenix) integration for GraphQL Elixir

Other

126 stars 7 forks source link

Closed aweiker closed 8 years ago

aweiker commented 8 years ago

Version that can only execute queries
Separate version that can load GraphiQL, fixes #16
Allow queries to be retrieved from the server side either through a function or from a passed in option
Upgrade to GraphiQL 0.6.1

joshprice commented 8 years ago

Looks good, nice work!

As discussed, we need to name the modules here more clearly:

[ ] Plug: this is the all singing, all dancing plug which does everything out of the box
[ ] Endpoint: this is the core plug that should only deal with executing the query
[ ] Parameters: seems like a reasonable name, maybe use singular?
[ ] FunctionalValue: does root_value processing? name and role need to be clearer

joshprice commented 8 years ago

Awesome work, thanks! :rocket: