search

graphql-go / graphql

An implementation of GraphQL for Go / Golang
MIT License
9.91k stars 839 forks source link

Implement Object.Definition() #465

Open KevinShiCA opened 5 years ago

KevinShiCA commented 5 years ago

The Object.Definition() method was stubbed to return an empty string. This PR makes it return gt.PrivateDescription.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.05%) to 92.399% when pulling 1119e3cbccc685f97f243ef8a14c6ce5a6a2bea8 on KevinShiCA:master into bed865f0458679ed5309c2cc4bfa82a2f84d8b5f on graphql-go:master.

siliconbrain commented 3 years ago

I just ran into this too, wrote the same patch, then found this PR before opening my own. Please, merge this! It's a one liner, the author even wrote a test for it.