graphql-go / graphql

An implementation of GraphQL for Go / Golang

MIT License

9.88k stars 840 forks source link

BindFields Improvement #503

Closed jekiapp closed 4 years ago

jekiapp commented 5 years ago

BindFields now will treat implementor of interface encoding.TextMarshaler as graphql.String. This will give ability to use time.Time or any encoding.TextMarshaler as a field type.

Issue ref:

415

coveralls commented 5 years ago

Coverage increased (+0.01%) to 92.391% when pulling 4452f5eaa6b2e19a623cf2d2392610b177c10962 on jekiapp:improve_bindfields into 9441c498a148d34c007886e14295e13eb3efc340 on graphql-go:master.

yoursunny commented 4 years ago

I ran into the time.Time issue today. Can the maintainer merge this PR?

chris-ramon commented 4 years ago

LGTM 👍 –– Thanks a lot @jekiapp 💯 🚢