search

graphql-go / graphql

An implementation of GraphQL for Go / Golang
MIT License
9.94k stars 841 forks source link

fix: input object with a nullable field set to null was being removed… #631

Open chirino opened 2 years ago

chirino commented 2 years ago

… from the Args map given to a resolver.

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.001%) to 91.993% when pulling 7c76e233491af20e78c647dc76fed0139282f490 on chirino:preserve-nil-input-fields into f02a1c961028d3ba7ac6bb22eaa09b31a2cb53dd on graphql-go:master.

ki4jnq commented 2 years ago

:+1: Running into this on our project, too. Seems there's an existing issue as well, https://github.com/graphql-go/graphql/issues/629

adaam2 commented 2 years ago

Can this be merged as we are also running into this?

kindermax commented 6 months ago

Hi, what chances are that this PR could be merged?

adaam2 commented 6 months ago

@kindermax As far as I can remember, I don't think that this PR is a complete implementation of nulls - we ended up forking this repo and doing it ourselves but I've since left that company so not sure I have access anymore.

kindermax commented 6 months ago

I see( Well for now I've overcome this by passing variables via context but it is a dirty hack.