search

graphql-go / handler

Golang HTTP.Handler for graphl-go
MIT License
445 stars 134 forks source link

Handle mutlipart/form-data #43

Open koblas opened 6 years ago

koblas commented 6 years ago

This PR should support Multipart form-data file upload requests as specified by https://github.com/jaydenseric/graphql-multipart-request-spec -- which is adopted by the Apollo team. It also works without file uploads as a general handler.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+2.6%) to 89.231% when pulling 5f3718a5f7508849cc33648407e5022030bb6887 on koblas:master into 59006c0464d5638788d7b0051ea5c959e0d84253 on graphql-go:master.

koblas commented 6 years ago

@chris-ramon Nudge - would it be possible to have this looked at?

duong-se commented 6 years ago

hi all, When will it merge to master ?

koblas commented 6 years ago

@chris-ramon Any chance that this could get a review, will clean up the conflict shortly.

appleboy commented 5 years ago

@koblas conflicts

koblas commented 5 years ago

@appleboy Conflicts resolved... Hopefully, someday @chris-ramon will feel like merging.

danjenson commented 4 years ago

Can we merge this?

hongbo-miao commented 3 years ago

While waiting this being merged, found an alternative handler supporting mutlipart/form-data created by @asif-mahmud.

Originally posted at https://github.com/graphql-go/graphql/issues/607 Library is at https://github.com/asif-mahmud/gingraphql

Just provide one more option 😃