I'm raising this mostly because I started poking at graphql-go/relay, /graphql, and the starter kit, and got a little confused. In node_test.go and node_global_test.go, the calls to NewNodeDefinition take the wrong prototype for the TypeResolve parameter. Fixing this so simple, even I was able to figure it out!
My questions, then, ...
Do you accept PRs directly to this repo? ... and if so, do you have a pattern to follow for branch names? Otherwise, I presume the best practice is to fork and issue a PR from there?
Will you accept a PR even if all tests are not passing? I haven't dug in enough to see what else is going on, but while they now compile, there are failures. Nevermind; figured out how to fix the tests.
I'm raising this mostly because I started poking at graphql-go/relay, /graphql, and the starter kit, and got a little confused. In
node_test.go
andnode_global_test.go
, the calls toNewNodeDefinition
take the wrong prototype for theTypeResolve
parameter. Fixing this so simple, even I was able to figure it out!My questions, then, ...
Will you accept a PR even if all tests are not passing? I haven't dug in enough to see what else is going on, but while they now compile, there are failures.Nevermind; figured out how to fix the tests.