Missing break statements after VALUE_FALSE in deserialize method

[lukaszstempin]

It looks like there is a missing 'break' after VALUE_FALSE. Without it, the boolean value always tries to parse as a number, which of course will never succeed.

case VALUE_FALSE:
case VALUE_TRUE:
   value = new BooleanValue(p.getBooleanValue());
case VALUE_NUMBER_FLOAT:
   value = new FloatValue(p.getDecimalValue());
   break;
case VALUE_NUMBER_INT:
   value = new IntValue(p.getBigIntegerValue());
   break;
case VALUE_STRING:
   value = new StringValue(p.getText());
   break;
case VALUE_NULL:
   value = null;
   break;
default:
   throw new JsonParseException(p, "Non managed JSON token: " + p.currentToken());
            }

My suggestion:

case VALUE_TRUE:
   value = new BooleanValue(p.getBooleanValue());
   break;

[lukaszstempin]

I wanted to raise a PR for this but looks like I am not able to do so.

Please make sure you have the correct access rights and the repository exists.

[etienne-sf]

Hello,

Thanks for the hint. I think everybody may submit PR. To do this:

• clone the project in GitHub, into your repositories.
• do the change.
• submit the PR

Étienne

[etienne-sf]

And an additional note: I'd be happy to validate this PR.

What would be even greater, is if you add Junit test that would be ko before the correction, and become ok after it.

[etienne-sf]

Question : do you plan to do this PR ? Otherwise I commit the correction you pointed out.

[lukaszstempin]

Hey @etienne-sf unfortunately I have no access to raise a PR. Sorry for that : /

[etienne-sf]

Ok, no problem

I'll commit this correction. :)

[etienne-sf]

Solved in the 2.3.1 release. Along with a bug that would prevent to use alias on field which type is a custom scalar.