graphql-java-kickstart / graphql-java-servlet

Servlet endpoint for GraphQL Java
https://www.graphql-java-kickstart.com/servlet/
Other
223 stars 114 forks source link

ci: build and publish javax flavour #522

Closed federicorispo closed 1 year ago

federicorispo commented 1 year ago

The 'release' github action has a new job to build the javax flavour of this project. This job has three main steps:

The cold migration from jakarta to javax is done via a new bash script .github/replaceJakartaWithJavax.sh that uses mainly the sed command to perform the replacement operations.

In gradle.properties the SOURCE_COMPATIBILITY and the TARGET_COMPATIBILITY constants are downgraded to 11 in order to allow the users to use the latest version of this library even in projects where the jdk11 is mandatory.

Updated the README with a brief explanation of the difference between the two flavours of this project.

oliemansm commented 1 year ago

@federicorispo Could you merge the two snapshot workflows as well the same way you did with release? So that when a snapshot is published it also publishes one for javax.

federicorispo commented 1 year ago

@oliemansm no problem, I will do it! What about tags? For now there is only one tag for both flavours: is it ok for you?

oliemansm commented 1 year ago

Yeah now that it's on one branch again that sounds ok 👍🏻