search

graphql-java-kickstart / graphql-java-servlet

Servlet endpoint for GraphQL Java
https://www.graphql-java-kickstart.com/servlet/
Other
223 stars 114 forks source link

Relaxed Jakarta Servlet API version to 5.x in GraphQL Java Servlet #524

Closed ideas-into-software closed 1 year ago

ideas-into-software commented 1 year ago

As per Federico Rispo's comment Federico Rispo's comment (https://github.com/graphql-java-kickstart/graphql-java-servlet/discussions/508#discussioncomment-5276382), GraphQL Java Servlet is dependent on Jakarta Servlet 6.x only because of Spring dependencies, which are only used for testing. Therefore, it was possible to relax Jakarta Servlet API version to 5.x, while keeping Jakarta Servlet API version at 6.x for 'testImplementation' dependencies.

Most of our projects use Apache Felix Jetty and requiring Jakarta Servlet 6.x made it impossible to use that container.

Thanks to this small change, GraphQL Java Servlet is now compatible with latest version of Apache Felix Jetty, as well as many other servlet containers which do not yet support Jakarta Servlet 6.x.

ideas-into-software commented 1 year ago

Possibly a separate branch, jakarta-servlet-5-x could be maintained, instead of merging to master?

juergen-albert commented 1 year ago

Is there any interesst in merging this, as we would highly appreciate this change as well.

federicorispo commented 1 year ago

@ideas-into-software We created the jakarta5 branch. ~Can you resolve the conflicts and point the PR to the jakarta5 branch?~ and it contains this change and we will make a release soon :rocket:

@oliemansm you can close this PR

ideas-into-software commented 1 year ago

Closing this as @federicorispo added this to https://github.com/graphql-java-kickstart/graphql-java-servlet/tree/jakarta5 branch via https://github.com/graphql-java-kickstart/graphql-java-servlet/commit/72fba8be2cb945eb38303efbfd1fa7c9ff996972 commit