search

graphql-java-kickstart / graphql-java-servlet

Servlet endpoint for GraphQL Java
https://www.graphql-java-kickstart.com/servlet/
Other
223 stars 114 forks source link

Add new GraphQLDirectiveProvider for custom directives #557

Closed gflores-jahia closed 7 months ago

gflores-jahia commented 7 months ago

https://github.com/graphql-java-kickstart/graphql-java-servlet/discussions/555

Currently graphql schema with custom directives can fail validation due to missing custom directive definitions when trying to build the schema.

Add new GraphQLDirectiveProvider to be able to insert these custom directive definitions and build/validate schema without issues.

federicorispo commented 7 months ago

Except from the two suggestions added, everything else looks good to me

federicorispo commented 7 months ago

@gflores-jahia Could you align/reopen this PR pointing the master branch? We are generating the artifact for the javax flavour in that branch during the build phase. The javax branch is no longer maintained because it was a test and we are able to have a javax flavour without a separate branch (see readme).