Closed hiddewie closed 1 month ago
@hiddewie Thank you very much for your time and effort on this PR. The alignment to graphql-java:22.1
looks good. I manually tested it on my personal project and it is working as expected.
Before merging it, I would like to remove the unused methods in the DataLoaderDispatchingSpec.groovy test class:
@federicorispo Thanks for the review!
I removed the dead code :)
@federicorispo Is it possible to make a new (major?) version with these changes?
Yes of course, but first I would like to test the other minor dependency bumps before merge them and release a new major (in a day or two).
If you want, you can test the snapshot version 15.2.1-SNAPSHOT
created on the master branch and available here
<repository>
<id>oss.sonatype.org-snapshot</id>
<url>https://oss.sonatype.org/content/repositories/snapshots</url>
<releases>
<enabled>false</enabled>
</releases>
<snapshots>
<enabled>true</enabled>
</snapshots>
</repository>
Perfect, thank you!
This PR makes the project compatible with GraphQL Java version 22
Changes:
com.graphql-java:graphql-java
version 22DataLoaderDispatcherInstrumentation
relatedRef https://github.com/graphql-java/graphql-java/pull/3447, which has most impact on this pull request.