search

graphql-java / graphql-java-extended-validation

Validation library for graphql-java input
MIT License
128 stars 34 forks source link

Issue upgrading to GraphQL-java 19.1 #73

Closed pelletier197 closed 2 years ago

pelletier197 commented 2 years ago

Describe the bug Directives were changed to AppliedDirective in GraphQL 19.1 it seems, which skips validations completely. Switching to AppliedDirective today seemed to have no impact at all. See #72

To Reproduce Upgrade to java-graphql 19.1, and normally all directives will fail to validate.

enriquedacostacambio commented 2 years ago

are you using graphql-java-tools? if so, i think the issue may happen due to upgrading that library rather than graphql-java. see: https://github.com/graphql-java-kickstart/graphql-java-tools/issues/695

Either way, upgrading graphql-java-extended-validation to use applied directives instead of old style ones bypasses this issue. +1 on you pr.

pelletier197 commented 2 years ago

Only missing a release of the library to fix the problem. Although I think it would be important to upgrade the library to use GraphQL version 19 as well.

dondonz commented 2 years ago

Closing as #72 has been merged.