Closed mac2000 closed 4 years ago
BTW: @types/express should be downgraded to 4.17.1 to match installed express version otherwise build is broken
patch versions in DT packages are totally independent and they increment it after each commit.
It was falling because node_modules
and src/editor/node_modules
had different express
version and one in src/editor/node_modules
was incompatible with this typing.
I refactored project setup to remove src/editor/node_modules
and also updated all dependencies.
@mac2000 BTW you can link commit to the issue it fixes so once PR is merged issue is automatically closed. https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
I do not know why but suddenly this one:
stops working in github actions and complaining with error
cp: cannot stat 'src/editor/*.{html,js,css,svg}': No such file or directory
after trying bazillion of workarounds the only way I was managed to pass actions was kind of ugly workaround like this one:
did tried on macos so it is definitely not related to windows and after all locally everything is ok and working as expected
wondering if I am the only one who experiencing this one
way to reproduce:
BTW:
@types/express
should be downgraded to4.17.1
to match installed express version otherwise build is brokenPS: did also checked thins one
runs-on: ubuntu-latest
inci.yml
which might cause this, but no, it still does not work even after telling it concrete ubuntu version