graphql-kit / graphql-faker

🎲 Mock or extend your GraphQL API with faked data. No coding required.
MIT License
2.69k stars 225 forks source link

Change 'random' to 'datatype' to fix deprecations in faker #149

Closed Robvio closed 3 years ago

Robvio commented 3 years ago

Fixes #148

fogelfish commented 3 years ago

Can you me the status of this fix? I'm using graphql-faker@2.0.0-rc.24 and I see these deprecation messages repeating in the terminal. Thank you.

Deprecation Warning: faker.random.number is now located in faker.datatype.number
Deprecation Warning: faker.random.uuid is now located in faker.datatype.uuid
IvanGoncharov commented 3 years ago

@Robvio Thanks a lot 👍 Sorry for the late merge.

IvanGoncharov commented 3 years ago

@Robvio @fogelfish Merged and released as v2.0.0-rc.25

fogelfish commented 3 years ago

Deprecation Warning: faker.random.uuid is now located in faker.datatype.uuid

...repeating in the terminal using the newest release:

$ graphql-faker --version 2.0.0-rc.25

sneko commented 2 years ago

@IvanGoncharov same as for @fogelfish .

Being spammed by:

Deprecation Warning: faker.random.uuid is now located in faker.datatype.uuid
Deprecation Warning: faker.random.uuid is now located in faker.datatype.uuid
Deprecation Warning: faker.random.uuid is now located in faker.datatype.uuid
Deprecation Warning: faker.random.uuid is now located in faker.datatype.uuid

even with 2.0.0-rc.25 🤔

EDIT: ok it's about this line https://github.com/Robvio/graphql-faker/blob/d30326244cd7fdfb21e714d912fd03cf597eb498/src/fake.ts#L181 that was not changed during this PR