graphql-kit / graphql-voyager

🛰️ Represent any GraphQL API as an interactive graph
https://graphql-kit.com/graphql-voyager/
MIT License
7.81k stars 516 forks source link

Import from local file instead of cdn in middlewares #330

Closed jscheffner closed 1 year ago

jscheffner commented 1 year ago

Hey, I just came across this comment on a different issue and was wondering if there are any opinions about this. I don't like depending on jsdelivr and would like to have everything included in my app. The files are already included in the npm package so for me it doesn't really make sense to import them via cdn.

Thank you for the PR, but for middleware middleware/render-voyager-page would it be possible to use a local file instead of the one from the cdn? That way it could work offline locally.

https://github.com/graphql-kit/graphql-voyager/issues/84#issuecomment-419494661

jscheffner commented 1 year ago

I guess serving the static files is a bit too complex so I'll close this issue