search

graphql-kit / graphql-voyager

🛰️ Represent any GraphQL API as an interactive graph
https://graphql-kit.com/graphql-voyager/
MIT License
7.69k stars 504 forks source link

Add keyboard shortcut ("/" key) to focus search input #380

Open navidadelpour opened 6 months ago

navidadelpour commented 6 months ago

Overview

This pull request adds a keyboard shortcut ("/" key) functionality in GraphQL Voyager, enabling users to focus on the search input. This enhancement aims to improve accessibility and empower users to search without relying on mouse interactions.

Peek 2024-01-05 21-20

navidadelpour commented 6 months ago

Hi @IvanGoncharov,

Can you please review this PR and let me know if there is any issue?

navidadelpour commented 5 months ago

@IvanGoncharov thanks for reviewing.

I will definitely check that in the next couple of days and let you know when it is updated.

navidadelpour commented 5 months ago

@IvanGoncharov Hi,

I Updated the PR and it's much more simpler. thanks for guidance. I didn't installed the react-event-listener because it's not compatible with react 18 and is archived on Github, I used an alternative package.

Also, as I was checking the PR#10725 you've sent and MUI code, I realized that this PR is not actually merged to the main branch right now. they are using @docsearch/react package and the way the package is implementing this feature is here.

Can you please review again?

LunaticMuch commented 5 months ago

@navidadelpour can you actually run tests and lint on your branch? PR tests for linting are failing

navidadelpour commented 5 months ago

Hi @LunaticMuch

Thanks for reminding me. I should have run them before my push! Would you please check again?