Middlewares, like graphql-shield, are catching global errors

[pantharshit00]

When adding a middleware to either graphql-yoga or to apollo-server, such as graphql-shield, and throwing an error on purpose in one of the resolvers, the middleware catches the Error and the original error is not being thrown/shown.

Reproduction

• Starting off with the blog example in the prisma-nexus repo
• Adding graphql-shield
  • yarn add graphql-shield
  • Adding it to the array of middlewares to graphql-yoga middlewares: [shield({})] - with or without any permissions)
• Add a throw new Error('message') in one of the resolvers
  • Ex: adding throw new Error('custom error message') to the first line of the blog query resolver method
• Making a request to the modified resolver
  • Ex: In graphql playground, executing the following query { blog(id: 1) {id} } will raise an error with the message being "Not Authorised!" instead of "custom error message"

Originally posted by @BenJeau on https://github.com/prisma/prisma2/issues/1680

[luhagel]

Afaik that is the case specifically with graphql-shield and documented as such.

https://github.com/maticzav/graphql-shield/blob/master/README.md#custom-errors

[BenJeau]

Ohh, I didn't know about that. It's weird that before upgrading to Prisma2, I didn't need to make adjustments to the way I was throwing the custom errors.

By making those changes, it now works as expected, thank you!

[luhagel]

Can we close this, @pantharshit00 ?

[pantharshit00]

I will leave that to @jasonkuhrt or @Weakky