graphql-perl / GraphQL-Plugin-Convert-DBIC

Plugin to convert DBIx::Class schema to GraphQL schema
https://metacpan.org/release/GraphQL-Plugin-Convert-DBIC
4 stars 5 forks source link

Use one resolver, not loads #13

Closed mohawk2 closed 5 years ago

mohawk2 commented 5 years ago

https://metacpan.org/release/GraphQL-Plugin-Convert-DBIC/source/lib/GraphQL/Plugin/Convert/DBIC.pm#L322 et seq are creating a mass of resolvers, whose major purpose is to close over $name which is available in the resolver's args.

The other purpose is to close over \%name2rel21, which should live under root_value in some way. Thanks @jjn1056 for questioning this ropy code!

mohawk2 commented 5 years ago

This is now resolved on master, and will be uploaded as 0.15 as soon as PAUSE returns. Closing.