search

graphql-python / graphene-django

Build powerful, efficient, and flexible GraphQL APIs with seamless Django integration.
http://docs.graphene-python.org/projects/django/en/latest/
MIT License
4.3k stars 768 forks source link

Add JSONField back to graphene_django.compat module for backwards compatibility #1429

Closed sjdemartini closed 1 year ago

sjdemartini commented 1 year ago

Fixes https://github.com/graphql-python/graphene-django/issues/1428 (after the change merged in https://github.com/graphql-python/graphene-django/pull/1421)

This should improve backwards compatibility, fixing issues in downstream packages (notably graphene-django-cud https://github.com/tOgg1/graphene-django-cud/issues/109, and also graphene-django-extras, both of which depended on graphene_django.compat.JSONField). I've tested this in my downstream project and confirmed it resolved issues in both of those packages.

sjdemartini commented 1 year ago

@firaskafri any chance you could take a look and see about merging this? Just a one-line change to fix backwards incompatibility. This is blocking my team from upgrading past 3.1.1 (and seemingly others like https://github.com/graphql-python/graphene-django/issues/1428). Thanks!