search

graphql-python / graphene-django

Build powerful, efficient, and flexible GraphQL APIs with seamless Django integration.
http://docs.graphene-python.org/projects/django/en/latest/
MIT License
4.3k stars 768 forks source link

Add support for Mypy type hinting #1438

Open PureTryOut opened 1 year ago

PureTryOut commented 1 year ago

Is your feature request related to a problem? Please describe. Our codebase is type checked using type hinting. There are stub packages for Django but graphene-django seems to be lacking it, thus importing anything from it causes Mypy to complain that error: Skipping analyzing "graphene_django": module is installed, but missing library stubs or py.typed marker [import]. It does so for just graphene as well.

Describe the solution you'd like graphene-django to export type hints.

ryanovas commented 1 year ago

seconded

ghost commented 1 year ago

If the maintainers approve, then I can start adding types to graphene-django, and in general graphene

50-Course commented 1 year ago

seconded. It would seem this involve project-wide type hinting? @PureTryOut

PureTryOut commented 1 year ago

I'm not sure what you want me to answer? I don't know, I'm not involved in development of this project, just a user.

50-Course commented 1 year ago

Thank you for clarifying. I have just gone through the source code myself. Thanks for signifying :)

firaskafri commented 1 year ago

If the maintainers approve, then I can start adding types to graphene-django, and in general graphene

I thin its a good idea.