search

graphql-python / graphene-django

Build powerful, efficient, and flexible GraphQL APIs with seamless Django integration.
http://docs.graphene-python.org/projects/django/en/latest/
MIT License
4.31k stars 769 forks source link

Prevent duplicate CI runs #1442

Closed kiendang closed 1 year ago

kiendang commented 1 year ago

We have this in our workflows

on: [push, pull_request]

This is redundant since when someone pushes to a PR branch, it triggers both push and pull_request synchronized which makes the action runs twice. Checking every PR CI and you will see we have the every check run twice (push) and (pull_request).

Just on: push is enough.

kiendang commented 1 year ago

Just learned that the reason for on: [push, pull_request] is that push does not trigger for PRs from forks (https://github.com/graphql-python/graphql-server/pull/117#pullrequestreview-1564006713). I've fixed this, but put in a new PR #1443 from my fork so we can test.