Optimize execute_graphql_request - Githubissues

graphql-python / graphene-django

Build powerful, efficient, and flexible GraphQL APIs with seamless Django integration.

http://docs.graphene-python.org/projects/django/en/latest/

MIT License

4.28k stars 766 forks source link

Optimize execute_graphql_request #1474

Closed kiendang closed 10 months ago

kiendang commented 10 months ago

This ported over graphql-core graphql_impl to speed up graphql execution by getting rid of duplicated steps. See https://github.com/graphql-python/graphene-django/pull/1393#issuecomment-1474258711 for context. This also paves the way for implementing support for validations rules (#1342, #1472)

This PR is basically just #1439 with some minor changes

Added the missing schema validation step in graphql_impl
Keep the show_graphiql arg. Agree with @danthewildcat that this arg is somewhat redundant but removing it is a non-backward compatible change.

kiendang commented 10 months ago

Actually I'll just push my commits into #1439