fix: properly use type hints

mahdyhamad commented 1 year ago

Description:

Python throws the TypeError: object is not subscriptable if you use indexing with the square bracket notation on an object that is not indexable.

To solve this issue, indexed types is used

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4042446135

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

11 of 11 (100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 91.111%

Totals
Change from base Build 3782172909:	0.04%
Covered Lines:	205
Relevant Lines:	225

💛 - Coveralls

erikwrede commented 1 year ago

Good catch! We should keep the 3.6-style type hints for list and dict until 3.10 is the oldest supported python version.

erikwrede commented 1 year ago

Can you fix the other affected files in the PR as well? It makes little sense to push a release that only supports half of that. If you have time, I can release it right after that 🙂

erikwrede commented 1 year ago

Thank you! 🙂

graphql-python / graphene-federation