graphql-python / graphene-federation

Federation implementation for Graphene.
MIT License
40 stars 10 forks source link

fix: Federation V2 Scalar Support #14

Closed arunsureshkumar closed 1 year ago

arunsureshkumar commented 1 year ago

Fix : Breaks with custom scalars #13

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4519903383

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
graphene_federation/utils.py 7 8 87.5%
<!-- Total: 9 10 90.0% -->
Totals Coverage Status
Change from base Build 4503776309: -0.2%
Covered Lines: 390
Relevant Lines: 430

πŸ’› - Coveralls
arunsureshkumar commented 1 year ago

Looks good, I wonder if we should rebase since there's 102 commits in the PR. But I guess we'll just squash this when merging 😊

Also /cc @erikwrede for a final check

Yes, It's happened somehow! Please squash this when merging!

erikwrede commented 1 year ago

Thanks for the quick fix! ☺️