graphql-python / graphene-federation

Federation implementation for Graphene.
MIT License
40 stars 10 forks source link

Add new line before field description #20

Open emilkholod opened 1 year ago

emilkholod commented 1 year ago

If we will generate SDL schema then we get:

"""Desc 1"""
type Object1 @key(fields: "field1") {
  """Desc field 1"""
  field1: DateTime
  """Desc field 2"""
  field2: ID
  """Desc field 3"""
  field3: String
  field4: String
  field5: String
}

but by default there should be a new line before descriptions:

"""Desc 1"""
type Object1 @key(fields: "field1") {
  """Desc field 1"""
  field1: DateTime

  """Desc field 2"""
  field2: ID

  """Desc field 3"""
  field3: String
  field4: String
  field5: String
}
emilkholod commented 1 year ago

Can anybody check this PR please?

erikwrede commented 1 year ago

Hey there, I'll check it out more closely this week.

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 5068006418

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
graphene_federation/service.py 2 3 66.67%
<!-- Total: 2 3 66.67% -->
Totals Coverage Status
Change from base Build 5063747249: -0.2%
Covered Lines: 393
Relevant Lines: 434

💛 - Coveralls